INT-NIT / BEP032tools

Software tools supporting the BIDS Extension Proposal (BEP) dedicated to adding support for electrophysiological data recorded in animal models (BEP032)
MIT License
3 stars 8 forks source link

Recoding the algorithm used for the checker #38

Closed SylvainTakerkart closed 3 years ago

SylvainTakerkart commented 4 years ago

As discussed after my comment (https://github.com/INT-NIT/AnDOChecker/pull/37#discussion_r496764260), the checker is working as expected, but the data structure used to perform the check (list) needs to be updated to be "cleaner"... Maybe use a tree and a tree-browsing algorithm instead of a list. Also, maybe it should take as input the abstract schema that was asked here (https://github.com/INT-NIT/AnDOChecker/issues/34).

We should clearly get inspiration from the BIDS Validator and eventually other equivalent pieces of software to see what's the cleanest way of doing this, and maybe what's the most computationally efficient...

SylvainTakerkart commented 3 years ago

This was solved by #40