search

INT-NIT / BEP032tools

Software tools supporting the BIDS Extension Proposal (BEP) dedicated to adding support for electrophysiological data recorded in animal models (BEP032)
MIT License
3 stars 8 forks source link

Ando tools #46

Closed Slowblitz closed 3 years ago

Slowblitz commented 3 years ago

Fix #45

SylvainTakerkart commented 3 years ago

Hi @Slowblitz ! I have a first suggestion: I think it'd be better if the andotools get installed directly when you run "pip install AnDOChecker"... (I think it will be too much to do pip install three times)

Also, for the CLI of the tools, use a capital letter at Creator and Viewer, so that AnDOCreator and AnDOViewer look the same as AnDOChecker which has a capital letter at Checker...

And while I'm writing, I would rename Creator into Generator (coz having both the Checker and the Creator start with a C is not optimal to exploit the command line autocompletion with the tab key... so let's choose something that does not start with a C, for example Generator)

I will look into more details later...

Slowblitz commented 3 years ago

Hello @SylvainTakerkart , So now one pip for AnDOChecker install the two other modules (cf: AnDOGenerator, AnDOViewer) I'll wait the merge of this branch to update the package on pypi perhaps we can go for a '0.4' now ?

SylvainTakerkart commented 3 years ago

Hi! I've cloned your branch and I'm trying to use the generator... But I have a problem:

~/tmp/AnDOChecker/tools/generator$ python ./AnDOGenerator.py exemple.csv ~/tmp/tmp_ando_data Successfully created the directory exp-neo/sub-enya/ses-20201201_001_none/derivatives Successfully created the directory exp-neo/sub-enya/ses-20201201_001_none/metadata Successfully created the directory exp-neo/sub-enya/ses-20201201_001_none/rawdata Successfully created the directory exp-neo/sub-enya/ses-20201201_002_none/derivatives Successfully created the directory exp-neo/sub-enya/ses-20201201_002_none/metadata Successfully created the directory exp-neo/sub-enya/ses-20201201_002_none/rawdata Successfully created the directory exp-neo/sub-enya/ses-20200201_003_none/derivatives Successfully created the directory exp-neo/sub-enya/ses-20200201_003_none/metadata Successfully created the directory exp-neo/sub-enya/ses-20200201_003_none/rawdata Successfully created the directory exp-neo/sub-zamba/ses-20201212_001_none/derivatives Successfully created the directory exp-neo/sub-zamba/ses-20201212_001_none/metadata Successfully created the directory exp-neo/sub-zamba/ses-20201212_001_none/rawdata Successfully created the directory exp-neo/sub-zamba/ses-20200203_010_none/derivatives Successfully created the directory exp-neo/sub-zamba/ses-20200203_010_none/metadata Successfully created the directory exp-neo/sub-zamba/ses-20200203_010_none/rawdata Successfully created the directory exp-aerial/sub-zimba/ses-20201206_001_none/derivatives Successfully created the directory exp-aerial/sub-zimba/ses-20201206_001_none/metadata Successfully created the directory exp-aerial/sub-zimba/ses-20201206_001_none/rawdata Successfully created the directory exp-aerial/sub-zimba/ses-20201201_010_none/derivatives Successfully created the directory exp-aerial/sub-zimba/ses-20201201_010_none/metadata Successfully created the directory exp-aerial/sub-zimba/ses-20201201_010_none/rawdata

Then I tried to look at the created directory, but I cannot find any:

~/tmp/AnDOChecker/tools/generator$ ls -l ~/tmp/tmp_ando_data total 0

So it seems the directories have been created, but I don't know where and I havn't found them yet... Can you check? Or am I doing something wrong?

Slowblitz commented 3 years ago

Yes it seems that I have forget to modify something when I separate the two modules... now works for me

SylvainTakerkart commented 3 years ago

@Slowblitz Soooo, I havn't been able to review this, sorry... Will do it as soon as I can! (but I've tested the code after your last commit, and it works for me!)

Slowblitz commented 3 years ago

Hello @SylvainTakerkart, It's ok if it seems to work =)

JuliaSprenger commented 3 years ago

ping?