Proposing a new algorithm for the Checker!

INT-NIT / BEP032tools

Software tools supporting the BIDS Extension Proposal (BEP) dedicated to adding support for electrophysiological data recorded in animal models (BEP032)

MIT License

3 stars 8 forks source link

Proposing a new algorithm for the Checker! #61

Closed SylvainTakerkart closed 3 years ago

SylvainTakerkart commented 3 years ago

OK, here is my code for the new checker... Note that I have added a mecanism for checking for the existence of the mandatory files. It can be run as the old one:

cd ando python newchecker.py -v tests/dataset004/exp-Landing

What needs to be done:

[ ] add new datasets to test it (take them from the ones available in https://github.com/INT-NIT/AnDO/pull/59)
[ ] add proper error handling
[ ] design unit tests (and probably add more datasets) to check that it does what it's supposed to!

SylvainTakerkart commented 3 years ago

@Slowblitz OK, it's all yours now! As discussed, make your list of checkboxes first ;)

Slowblitz commented 3 years ago

So as we discuss earlier I'll continue this PR, there is still some stuff to be done as describe below :

[x] Fix the TODO in the AnDOChecker.py
[ ] add new datasets (One dataset per "rules" for each level)
[ ] Add new unit test that check regexp and overall functioning (this one should be done first if we want to do it in a "test driven development" way).
[ ] Add the generate regexp function
[ ] add a proper Error handling

Feel free to add task that I have maybe forgot =)