Newchecker

[Slowblitz]

Taking over #61 : So as we discuss earlier I'll continue this PR, there is still some stuff to be done as describe below :

• [x] Fix the TODO in the AnDOChecker.py
• [x] add new datasets (One dataset per "rules" for each level)
• [x] Add new unit test that check regexp and overall functioning (this one should be done first if we want to do it in a "test driven development" way).
• [x] Add the generate regexp function
• [ ] add a proper Error handling

Feel free to add task that I have maybe forgot =)

[JuliaSprenger]

Hi @Slowblitz I pushed some updates directly to your branch, don't be surprised when pushing the next time ;) However, tests are still failing :/

[Slowblitz]

Yes test are still failing =/ but thx for the update, so I have to pull now, so we don't get any conflict . Also I guess we have to change all dataset descriptions in our dataset to fit the test no ?

[JuliaSprenger]

I also adjusted the datasets. The failing tests are related to the old version of the generator in this branch and with the new version the tests are actually succeeding, see https://github.com/INT-NIT/AnDO/pull/62

[Slowblitz]

Ok so maybe it's time to delete the old one no ?

[JuliaSprenger]

Yes, we can do that. I hope this won't mess up me rebasing the new generator on this branch :crossed_fingers:

[JuliaSprenger]

@Slowblitz so should I or do you want to do this?

[Slowblitz]

You can do it =)

[JuliaSprenger]

Tadaaa

[Slowblitz]

\o/ yeaaaa good job =)

[JuliaSprenger]

Regarding the last open checkbox for this PR, the error handling, I suggest to leave it as it is right now (the is_valid function returning a bool indicator and a list of error messages as this output is well defined and can be used by different interfaces (python scripts, webchecker,...)

[SylvainTakerkart]

OK, the tests are failing coz there's a problem with a relative import... I need to fix this!

[SylvainTakerkart]

@JuliaSprenger OK, tests pass! I let you merge if you want to take a look (or merge directly)...