Enhance Checker - Githubissues

INT-NIT / BEP032tools

Software tools supporting the BIDS Extension Proposal (BEP) dedicated to adding support for electrophysiological data recorded in animal models (BEP032)

MIT License

3 stars 8 forks source link

Enhance Checker #66

Closed JuliaSprenger closed 3 years ago

JuliaSprenger commented 3 years ago

This PR improves the checker by

fixing incompatibilities between the BEP specs and the rules
making the authorized and mandatory folder rules more consistent across levels
adding a test (dataset) with a complete set of metadata files

JuliaSprenger commented 3 years ago

Yes, that was exactly the idea. Before we still had accidentally listed an exp- folder in the rules and the removal of this required this bigger cleanup and reorganization...

SylvainTakerkart commented 3 years ago

actually, it was not accidental... but it was guided by something that's not in the BIDS-animal-ephys specs, which is the naming of the top-level directory with exp-XXX ; this is something I'd like to keep if possible... any idea what we could do about this?

SylvainTakerkart commented 3 years ago

could we add an extra rule (the one on the exp-XXX top-level folder)? and this rule would be checked only for internal INT use with a flag to be added on the command line? it's not very clean, but it would do the job...

actually, I'm not sure what to think about this... it probably relates to what we want to do with DigLab2AnDO and the AnDOGenerator... shall we discuss this in the next few days?

JuliaSprenger commented 3 years ago

I thin this should be part of the DigLab2AnDO code and AnDO itself should be only dealing with the AnDO specs. Maybe we can have a utility validation function in the DigLab2AnDO repo that is running the AnDO validation and some additional INT specific checks, like the exp- parent folder.

SylvainTakerkart commented 3 years ago

OK, this makes sense, let's go this way!