Closed killianrochet closed 3 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
redcap_bridge/project_building.py | 10 | 11 | 90.91% | ||
<!-- | Total: | 10 | 11 | 90.91% | --> |
Totals | |
---|---|
Change from base Build 1417354997: | 0.04% |
Covered Lines: | 310 |
Relevant Lines: | 346 |
HI @killianrochet
Could you try to add the print statements independently for each function in this module? E.g. for now focus on the build_project
function and only add a print statement at the end of it summarizing what it did.
HI @killianrochet Could you try to add the print statements independently for each function in this module? E.g. for now focus on the
build_project
function and only add a print statement at the end of it summarizing what it did.
Yes no problem, I will add print statement only on build and customize function !
Hello @killianrochet! Thanks for updating this PR.
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Hi @killianrochet I added an automated pep8 check to the repository. So you can see all the pep8 incompatible lines in the automated comment above by 'pep8speaks'. Fixing those should be easy in pycharm, but running the automatic code formatting on the complete file.
@killianrochet Do you plan any more changes here? Otherwise I would merge this PR now.
No, for me it's okay you can merge
Hi @killianrochet ! Thanks for opening the PR. The tests are currently failing due to the pycap installation not working properly, so it is not related to your changes. I fixed this in another PR (#26). Once PR #26 is merged you need to update your local master branch (add a new upstream remote that is pointing to the INT-NIT master) and rebase your enh/printbuildinginfos branch onto that. Once you push these changes then to your fork the tests should also work here.
PS: Please provide also a short comment for your PR to describe what that this PR is about.