search

INT-NIT / DigLabTools

MIT License
2 stars 4 forks source link

Refactor to create `elab_bridge` package equivalent to `redcap_bridge` #78

Closed JuliaSprenger closed 1 year ago

JuliaSprenger commented 1 year ago

This PR moves the existing elab-based functionality into a dedicated module elab_bridge and adds equivalent submodules to redcap_bridge. This includes project building, validation and cli.

Some functionality is not implemented yet and therefore raises NotImplemented errors when called. Corresponding tests are added for consistency, but will be skipped by pytest as they are marked to be skipped. The corresponding functionality will be added in separate PRs later on.

JuliaSprenger commented 1 year ago

Tests are passing! @killianrochet Do you mind having a look if you see something very weird in there?

killianrochet commented 1 year ago

@JuliaSprenger Everything looks OK, I think it's better to differentiate RedCap from Elab for the clarity of the code and future development, which I think will be positive.

JuliaSprenger commented 1 year ago

OK, then feel free to merge @killianrochet If you notice something requiring changes later on feel free to open an issue.