INTO-CPS-Association / DTaaS-examples

Examples to demonstrate the features of DTaaS software
https://into-cps-association.github.io/DTaaS/development/user/examples/index.html
3 stars 8 forks source link

Incubator integration #28

Closed mortenhaahr closed 7 months ago

mortenhaahr commented 7 months ago
prasadtalasila commented 7 months ago

@mortenhaahr Thanks for the PR. It works as expected.

Please see the suggested changes:

  1. Remove the unused files, ex: godot files, tests, past experimental data and any other unused python modules.
  2. Update the README with explanation of the results seen in Influx dashboards. If there is a way to upload the Influx dashboard config (like done in firefighter example), that would be great. Add a couple of useful screenshots from InfluxDB dashboards.
  3. Add the URL of incubator github repo, and commit hash of the code taken from the incubator git repo. It will be handy later on.

Thanks.

prasadtalasila commented 7 months ago

@mortenhaahr is this a work-in-progress or are you waiting for my review?

mortenhaahr commented 7 months ago

@mortenhaahr is this a work-in-progress or are you waiting for my review?

This is still a work-in-progress.

mortenhaahr commented 7 months ago

Please see the suggested changes:

1. Remove the unused files, ex: godot files, tests, past experimental data and any other unused python modules.

2. Update the README with explanation of the results seen in Influx dashboards. If there is a way to upload the Influx dashboard config (like done in firefighter example), that would be great. Add a couple of useful screenshots from InfluxDB dashboards.

3. Add the URL of incubator github repo, and **commit hash** of the code taken from the incubator git repo. It will be handy later on.

@prasadtalasila Done with 1 and 3. I propose we create an issue for 2 and handle it after tutorial submission.

That way I can merge this PR and start integrating the other Incubator examples.