search

INTO-CPS-Association / DTaaS

:factory: :left_right_arrow: :busts_in_silhouette: Digital Twin as a Service
https://into-cps-association.github.io/DTaaS/
Other
116 stars 57 forks source link

[BUG] Hardcoded constants in runner #1021

Closed prasadtalasila closed 3 weeks ago

prasadtalasila commented 1 month ago

Describe the bug

The runner has the default config file and package version hardcoded.

To Reproduce

Check commander.ts

The default config filename is hardcoded in line-23 (as runner.yml) while the package version is hardcoded in line-7.

Expected behavior

The config filename should be mentioned as constant at the top of commander.ts

const DEFAULT_CONFIG_FILENAME = 'runner.yaml'

and the package version should be updated to the latest version.

prasadtalasila commented 3 weeks ago

PR #1042 solves this problem