search

INTO-CPS-Association / DTaaS

:factory: :left_right_arrow: :busts_in_silhouette: Digital Twin as a Service
https://into-cps-association.github.io/DTaaS/
Other
116 stars 57 forks source link

Add path prefixed gitlab-ce instance #905

Closed aryanpingle closed 1 month ago

aryanpingle commented 2 months ago

PR to address #892 and #899

prasadtalasila commented 2 months ago

@aryanpingle

Please add INTEGRATION.md detailing the steps required for integrating gitlab with the rest of DTaaS installation. It is a three step process

  1. Bring up DTaaS with unchanged OAUTH information in env.js, .env.server and conf.server.
  2. Bring up and configure /gitlab (the current README.md)
  3. Create OAUTH apps in the new gitlab
  4. Update OAUTH information in env.js, .env.server and conf.server.
prasadtalasila commented 2 months ago

@aryanpingle Another important explanation is with regards to self-signed / invalid TLS certificates. The OAuth2 server authorization fails if either self-signed or invalid certificates are used. So a clear emphasis needs to be made saying that the gitlab integration is only possible with a valid TLS certificate. Please do verify the existence of this problem before tomorrow's meeting. Thanks.

aryanpingle commented 2 months ago

Can confirm, authorization fails with a self-signed/invalid certificate (OAuth2 redirect results in Service unavailable). I'll update the docs to mention this.

codeclimate[bot] commented 2 months ago

Code Climate has analyzed commit 7ac65812 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 3

View more on Code Climate.

prasadtalasila commented 1 month ago

merged via #961. Thanks @aryanpingle for the contribution.