search

INTO-CPS-Association / DTaaS

:factory: :left_right_arrow: :busts_in_silhouette: Digital Twin as a Service
https://into-cps-association.github.io/DTaaS/
Other
116 stars 57 forks source link

only publish docker image if version is not yet published #926

Closed nichlaes closed 2 months ago

nichlaes commented 2 months ago

@prasadtalasila this should fix the #854

prasadtalasila commented 2 months ago

@nichlaes can you make a minor correction in client or servers/lib directory and see if this is enforced? Or is there an easy way to check the functioning of this PR?

prasadtalasila commented 2 months ago

The client/config/dev.js requires correction. The updated content of this file is:

if (typeof window !== 'undefined') {
  window.env = {
    REACT_APP_ENVIRONMENT: 'dev',
    REACT_APP_URL: 'http://localhost:4000/',
    REACT_APP_URL_BASENAME: '',
    REACT_APP_URL_DTLINK: '/lab',
    REACT_APP_URL_LIBLINK: '',
    REACT_APP_WORKBENCHLINK_VNCDESKTOP: '/tools/vnc/?password=vncpassword',
    REACT_APP_WORKBENCHLINK_VSCODE: '/tools/vscode/',
    REACT_APP_WORKBENCHLINK_JUPYTERLAB: '/lab',
    REACT_APP_WORKBENCHLINK_JUPYTERNOTEBOOK: '',

    REACT_APP_CLIENT_ID: '1be55736756190b3ace4c2c4fb19bde386d1dcc748d20b47ea8cfb5935b8446c',
    REACT_APP_AUTH_AUTHORITY: 'https://gitlab.com/',
    REACT_APP_REDIRECT_URI: 'http://localhost:4000/Library',
    REACT_APP_LOGOUT_REDIRECT_URI: 'http://localhost:4000/',
    REACT_APP_GITLAB_SCOPES: 'openid profile read_user read_repository api',
  };
};
prasadtalasila commented 2 months ago

The servers/lib/DEVELOPER.md requires correction in the following table.

| OS      | Absolute Path                 | Relative Path |
| ------- | ----------------------------- | ------------- |
| Windows | C:\DTaaS\files                | ..\..\files  |
| Linux   | /Users/\<Username\>/DTaaS/files | ../../files   |
nichlaes commented 2 months ago

@prasadtalasila I have reset the changes and tested it locally. Should we merge this and test it on the client?

codeclimate[bot] commented 2 months ago

Code Climate has analyzed commit 35de4313 and detected 0 issues on this pull request.

View more on Code Climate.