search

INTO-CPS-Association / DTaaS

:factory: :left_right_arrow: :busts_in_silhouette: Digital Twin as a Service
https://into-cps-association.github.io/DTaaS/
Other
115 stars 57 forks source link

Upgrades client dependencies #945

Closed atomicgamedeveloper closed 2 weeks ago

atomicgamedeveloper commented 1 month ago

Upgrading the project's dependencies as specified in issue #893.

prasadtalasila commented 1 month ago

@atomicgamedeveloper

Thanks for the PR. Please look into the following suggestions.

  1. Upgrade all dependencies to th latest versions available. Choose an earlier version only if there is a breaking compatibility issues.
  2. Keep the first letter of a function in lowercase and that of class in uppercase. I know the distinction is a bit thin in Javadcript but keeping the distinction hopefully aids the readability.
  3. There are many minor formatting changes. Are they the outcome of yarn format command?
prasadtalasila commented 1 month ago

The Github action of libms has been improved to include checks on both Windows and Linux OS environments. Please add this change to client as well.

prasadtalasila commented 1 month ago

@atomicgamedeveloper please let me know when this PR is ready for my next review. Thanks.

prasadtalasila commented 4 weeks ago

@atomicgamedeveloper There is a problem with the client dependency upgrade PR. It broke two things.

  1. yarn gitlab:compile && yarn gitlab:run (please see end of DEVELOPER.md for explanation of these two commands)
  2. The Digital Twin Preview page (this is undocumented. Perhaps @VanessaScherma can take a meeting with you to cross check the problem)
prasadtalasila commented 3 weeks ago

@atomicgamedeveloper please rebase to feature/distributed-demo branch

codeclimate[bot] commented 2 weeks ago

Code Climate has analyzed commit 87881397 and detected 0 issues on this pull request.

View more on Code Climate.