INTO-CPS-Association / DTaaS

:factory: :left_right_arrow: :busts_in_silhouette: Digital Twin as a Service
https://into-cps-association.github.io/DTaaS/
Other
116 stars 57 forks source link

Fixes the stalling dev container #989

Closed atomicgamedeveloper closed 2 weeks ago

atomicgamedeveloper commented 1 month ago

Pull Request Template

Title

Fixes the stalling dev container

Type of Change

Description

I exchanged the ghcr.io/devcontainers-contrib/features/mkdocs:2 which derives from a currently inactive repo to the corresponding layer from the active fork of it, https://github.com/devcontainers-extra/features?tab=readme-ov-file.

Testing

I successfully have built the dev container. This was infeasible before.

Impact

Additional Information

Issue discussing this: https://github.com/devcontainers-contrib/features/issues/623

Checklist

prasadtalasila commented 1 month ago

The other layers may eventually stop working unless the original repository reactivates.

@atomicgamedeveloper what does this mean? I thought the layers are independent!

prasadtalasila commented 1 month ago

Please upgrade the node to v22.x and yarn to the latest version. Please also upgrade the dependencies and layers to their latest versions.

atomicgamedeveloper commented 1 month ago

The other layers may eventually stop working unless the original repository reactivates.

@atomicgamedeveloper what does this mean? I thought the layers are independent!

The other feature layers come from the same inactive repository, so they may face similar issues down the line when we rebuild. A simple solution is just to replace all the sources to the active one.

Please upgrade the node to v22.x and yarn to the latest version. Please also upgrade the dependencies and layers to their latest versions.

Will do now.

codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit a94ad405 and detected 0 issues on this pull request.

View more on Code Climate.

prasadtalasila commented 2 weeks ago

There is a new PR #1063 that is equivalent to this PR.