INTO-CPS-Association / hybrid-cosim-framework

A native framework for generated hybrid co-simulations
GNU General Public License v3.0
0 stars 0 forks source link

Invalid OutRule #2

Open CThuleHansen opened 6 years ago

CThuleHansen commented 6 years ago

Since the condition is commented in: https://github.com/INTO-CPS-Association/hybrid-cosim-framework/blob/1545c9493a98e678a8c9050dfea7e069e5c7d013/semantic-adaptation/src/SemanticAdaptation.h#L246-L249

The OutRulesBlock is executed when the external FMU is Mealy and setInputX is performed on the External FMU: https://github.com/INTO-CPS-Association/hybrid-cosim-framework/blob/1545c9493a98e678a8c9050dfea7e069e5c7d013/semantic-adaptation/src/SemanticAdaptation.h#L226-L230

This leads to setInputs on the Internal FMUs followed by GetOutputs on the Internal FMUs, which is not allowed!

I need help clarifying the correct behaviour.

CThuleHansen commented 6 years ago

Inform the user that this is not allowed according to the FMI standard, and therefore Mealy should not be used without this is mind.