App converted to react - Githubissues

INTO-CPS-Association / into-cps-application

The front-end of the INTO-CPS tool chain

https://into-cps-association.github.io/simulation/app.html

Other

17 stars 8 forks source link

App converted to react #232

Closed PandoraQS closed 2 weeks ago

PandoraQS commented 1 month ago

Converted the App skeleton to React:

Fully working, including MUI.
Kept the original layout for the main window.
Included the developer tools toggle and dark theme toggle in the Electron menu of the app.
Imported everything that is needed at the moment
Installed Prettier, Eslint and Jest.
Removed Gulp.

To be done:

Check the configuration to compile the application with Webpack and Babel to build it with Electron Builder.
Improve the configuration files (Eslint, Prettier, Jest) using the ones provided.
Fix current ESLint errors and Tests in Jest
UI Mocks

prasadtalasila commented 3 weeks ago

@PandoraQS I suggest the following potential improvements.

The README.md needs to be updated for the new code
The npm run syntax and npm run dist throws errors.
Please remove the babel dependencies

prasadtalasila commented 3 weeks ago

@PandoraQS The npm run start fails on Linux as well due to the sandbox issue you mentioned. Please update DEVELOPER.md with instructions and links to disabling sandbox settings in Ubuntu 24.04 in addition to Windows solution. Thanks.

PandoraQS commented 3 weeks ago

Removed babel and webpack, integrated esbuild.
npm run dist works on Ubuntu and Windows, but cannot be used to build for different OS's in the same OS.
included --no-sandbox for the SSUID error