search

INTO-CPS-Association / maestro

Maestro a Co-Simulation Orchestration Engine
https://build.overture.au.dk/jenkins/job/maestro/
20 stars 3 forks source link

Make it possible to retrieve specification even if execution failed. #344

Closed CThuleHansen closed 2 years ago

CThuleHansen commented 2 years ago

Adapt the web api such that this is possible. see https://github.com/INTO-CPS-Association/into-cps-application/issues/165

FrederikPM commented 2 years ago

I've have looked into the wep-api and I can see that we have the endpoint: "/result/{sessionId}/zip". It returns everything in the working directory, where the specification is places as soon as it has been generated. So I think client should be able to retrieve the specification from this endpoint before terminating the session by calling "/destroy/{sessionId}". Should we make an endpoint that only returns the specification?

CThuleHansen commented 2 years ago

I think you are completely correct. My bad :)

FrederikPM commented 2 years ago

Okay. I will close this issue when the accompanying issue has been closed.

CThuleHansen commented 2 years ago

What is the accompanying issue? If you cannot remember (I cannot), then just close the issue, and it can be reopened if needed.

FrederikPM commented 2 years ago

The accompanying issue is in the Into-cps-application repo, I should probably have linked to it before. However, I think that we can safely conclude that only changes to the app is needed and therefore close this issue.