INTO-CPS-Association / maestro

Maestro a Co-Simulation Orchestration Engine
https://build.overture.au.dk/jenkins/job/maestro/
20 stars 3 forks source link

Builder settings state is not passed from parent to child. #356

Open FrederikPM opened 2 years ago

FrederikPM commented 2 years ago

In the Sigver plugin the builder settings are passed with their default value although they are set to different values in the parent.

CThuleHansen commented 2 years ago

I think we should make an interface to the expansion plugins, such that it is expanded directly instead of Maestro Machinery to do it. This would avoid these issues.

@FrederikPM what sort of issues are you seeing because of this?

Of course, this means that the support for writing expand in a MaBL specification by hand will deteriorate over time.. @lausdahl input on this?

FrederikPM commented 2 years ago

@CThuleHansen at the moment it does not cause any issues. I just discovered this when looking into a separate issue.