search

INWTlab / rsync

R Package as interface to rsync
Other
17 stars 4 forks source link

listFiles does not like filenames with spaces #9

Closed raymondben closed 2 years ago

raymondben commented 2 years ago

https://github.com/INWTlab/rsync/blob/master/R/listFiles.R#L21 will split file/directory names that have spaces in them

wahani commented 2 years ago

@raymondben Thanks for taking the time to report this issue!

I have prepared a fix which you may try after installing the patched version with:

remotes::install_github("INWTLab/rsync", ref = "feature/9_listFiles-does-not-like-filenames-with-spaces")

Can you please also provide an example of your use case, so that I can make sure it is now covered by the test cases?

raymondben commented 2 years ago

@wahani thanks, see comments in https://github.com/INWTlab/rsync/pull/11

wahani commented 2 years ago

@raymondben thanks again. The patch is in master now. You can receive updates using:

options(repos = c(getOption("repos"), INWTLab = "https://inwtlab.github.io/drat/"))
install.packages("rsync")