IO-Aerospace-software-engineering / Astrodynamics

Astrodynamics framework
https://www.io-aerospace.org/
GNU Lesser General Public License v2.1
20 stars 1 forks source link

Suspicious radius/altitude results for planetocentric and planetodetic calculations #193

Closed szabolcsvelkei closed 2 months ago

szabolcsvelkei commented 2 months ago

Describe the bug Suspicious radius/altitude results for planetocentric and planetodetic calculations

To Reproduce Use an observation site for example from here: https://www.jostjahn.de/stations/W57.html https://www.jostjahn.de/stations/K88.html Calculate plantetocentric values from planetodetic or vice versa Result: Wrong radius/altitude

Expected behavior Precise numbers (~rounding errors)

Screenshots N.A.

Desktop (please complete the following information):

Additional context N.A.

sylvain-guillet commented 2 months ago

Hi @szabolcsvelkei, thanks for your feedback.

I studied your problem and here is my explanation:

I first created planetodetic and planetographic coordinates, converted one to the other, then compared the result with JPL WebGeocalc (https://wgc.jpl.nasa.gov:8443/webgeocalc/#StateVector) and the results are strictly the same.

When I look at the result on your site, I think the "Altitude" property refers to the AMSL Altitude (Above mean sea level) but IO Framework uses the definition given by JPL: "altitude is the altitude of the point above the reference spheroid" (https://wgc.jpl.nasa.gov:8443/webgeocalc/documents/coordinateSystemHelp_L2.html) and this explains why we don't have the same result, it's because we don't use the same reference (Elipsoid vs Mean sea level)

That being said, I think the term "altitude" is confusing and many people expect the AMSL altitude, I could change the term Altitude to Geodesics Height to be more precise.

Today the framework does not provide a method to calculate the AMSL Altitude and this could be an interesting improvement for the next version.

Sylvain

szabolcsvelkei commented 2 months ago

Thank you for the explanation.