search

IO500 / io500

IO500 Storage Benchmark source code
MIT License
98 stars 31 forks source link

Verify score hash does not match generated one #33

Closed mchaarawi closed 3 years ago

mchaarawi commented 3 years ago

When running the verify phase over the generated results.txt file, I found that the score hash is always failing with the isc21 tag. After some digging I found the issue to be that the hash generation in the verifier program adds more items to calculate the hash vs what the original program does to compute the hash when the benchmark is run. Specifically those three items are added by the verifier but were not used when computing the score hash in the benchmark: timestamp score BW score MD score

JulianKunkel commented 3 years ago

Thanks for reporting. Your analysis is correct. The PR will resolve this issue.

johannlombardi commented 3 years ago

Thanks @JulianKunkel. Could you please advise whether we shall we apply it for ISC21 submissions or stick to the original tag?

mchaarawi commented 3 years ago

Confirmed the PR does resolve the issue. Same question as Johann as what the committee is going to require for isc21..

adilger commented 3 years ago

Patch included in io500-isc21_v2 tag.