IO500 / io500

IO500 Storage Benchmark source code
MIT License
95 stars 30 forks source link

Set the aiori mpi rank before initializing drivers #60

Closed mchaarawi closed 1 year ago

mchaarawi commented 1 year ago

The global rank variable in ior and mdtest is not set till after the aiori backends are intialized in the main io500 app. This PR sets this global variable.

gflofst commented 1 year ago

I don't see where rank is referenced. This change doesn't seem to do anything unless it is used by the linked in code. Is that the case?

mchaarawi commented 1 year ago

I don't see where rank is referenced. This change doesn't seem to do anything unless it is used by the linked in code. Is that the case?

Right, this is defined/used in the context of thr ior repo. It's initialized in the ior main function before the driver specific init functions are called if using ior directly. io500 does not use ior_main but does the driver init first itself and then calls ior_run which initializes that variable, but too late since we already initialized the drivers here.