search

IOES-Lab / dave

Project DAVE
Apache License 2.0
11 stars 1 forks source link

[GSOC-62] Added buoyancy plugin to the world files #7

Closed rakeshv24 closed 4 months ago

rakeshv24 commented 4 months ago

In this PR, we add the buoyancy plugin to the world files. The default seawater density is set to 1025 kgm^-3.

hmoyen commented 4 months ago

Nice, works well! Thank you @rakeshv24

Just something I've noticed: in my machine, in the dave_electrical_mating world, the rexrov surfaces considerably slower compared to other worlds. It might be that this simulation is heavier, but it does eventually surface :)

rakeshv24 commented 4 months ago

Thank you @hmoyen !

That is an interesting observation and I agree with your reasoning behind it.

rakeshv24 commented 4 months ago

Yeah I thought about that as well. Let's hope they make it more generalized, so that it can be used at any sdf level.