IOMirea / jarpc

Just another RPC library
https://jarpc.readthedocs.io
GNU General Public License v3.0
5 stars 2 forks source link

issue: #7 | PyTest, Makefile & Coverage Report #22

Closed suv27 closed 5 years ago

suv27 commented 5 years ago

Description:

Start unit tests for yarpc/*.py Python files. For Help, run make help

Tasks

  • [x] Unit test enums.py
  • [x] Unit test constants.py
  • [x] Integrated pytest & name-tests-test into Travis CI Pipeline.
  • [x] Integrated the coverage report to the project.

Pre-Pull Request Checklist:

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7d04bfa). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #22   +/-   ##
=========================================
  Coverage          ?   46.84%           
=========================================
  Files             ?       11           
  Lines             ?      333           
  Branches          ?        0           
=========================================
  Hits              ?      156           
  Misses            ?      177           
  Partials          ?        0
Impacted Files Coverage Δ
tests/unit/client_test.py 100% <ø> (ø)
tests/unit/constants_test.py 100% <100%> (ø)
tests/unit/enums_test.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d04bfa...7e17cac. Read the comment docs.

Fogapod commented 5 years ago

Unit Tests for the enums.py file and let me know if this is how you want it done.

This looks like what I wanted.

I'm not sure about file/folder naming though. Tests are usually named using snake_case and aren't strictly tied to classes. They're rather grouped by functionality. Examples:

suv27 commented 5 years ago

How would you want the structure for the test files inside of tests/? The rest of the python files that need to I need to test it are this: python files I do not see any more inside of this repo.

Fogapod commented 5 years ago

tests/unit is fine

Fogapod commented 5 years ago

@Physsix27 Will you be adding other tests to this pr or it's ready?

suv27 commented 5 years ago

@Fogapod @Gelbpunkt This PR is ready, I will make another PR specifically targeting tests. Let me know if anything is missing for this PR