Integrate Black, Flake8, & MyPy into yarpc and Travis Config

IOMirea / jarpc

Just another RPC library

https://jarpc.readthedocs.io

GNU General Public License v3.0

5 stars 2 forks source link

Integrate Black, Flake8, & MyPy into yarpc and Travis Config #23

Closed suv27 closed 4 years ago

suv27 commented 4 years ago

[ ] Integrate Flake8 to Makefile
[ ] Integrate Black to Makefile
[ ] Integrate MyPy to Makefile
[ ] Integrate all thoses targets into Travis CI Pipeline

suv27 commented 4 years ago

I will be working on this issue, please assign to me.

Fogapod commented 4 years ago

These tools are already used for testing. Although they are are in pre-commit and there are some issues running pre-commit with Travis. It would be better to add these to makefile and run them from Travis. Project uses mypy and black, so add them to list please. Pylint is probably not needed

suv27 commented 4 years ago

Hey @Fogapod, just so I understand the problem I am facing with this issue, do you want me to add FLAKE8, BLACK & MYPYto the Makefile and also ensure that they get added to Travis as well? Is this going to be a pre-requisite, meaning if there is a bug with any of them ☝️ Travis should FAIL?

Fogapod commented 4 years ago

These linting tools should be included into Makefile. Travis should use Makefile instead of pre-commit. This should happen in script section. So if something errors, other commands in script will still be executed, but build will fail with error and coverage won't be submitted.