Jack-McDowell
commented
1 year ago I can't approve this for a couple of reasons.
- Looks like you somehow messed up the submodules - their files are being considered part of BLUESPAWN, which shouldn't be the case. Make sure they're still submodules and not just repos dumped in bluespawn's source directories.
- I'm seeing a lot of source files being recorded as completely changed when they're not really being touched. That screws up git history. I'm guessing you swapped tabs for spaces or something.
- Changes like this should go into develop, not master. We keep master pointing to the latest version of release code.
If you clean the git stuff up, it should be good (once I confirm with a bit of testing)!
harryeetsource
Bluespawn.cpp changes: catch(const std::exception& e) { Bluespawn::io.InformUser(StringToWidestring(options.help())); LOG_ERROR(e.what()); Eventlog.cpp changes: // Open the channel config EventWrapper hChannel{ EvtOpenChannelConfig(NULL, channel.c_str(), 0) }; if(reinterpret_cast(NULL) == hChannel) {
LOG_ERROR(L"EventLogs::IsChannelOpen: EvtOpenChannelConfig failed with " + std::to_wstring(GetLastError()) +
L" for channel " + channel);
return false;
}