IONISx / edx-theme

Open edX responsive theme using Bootstrap
http://ioni.sx
54 stars 102 forks source link

CSS style not updated #50

Open DanielZuwala opened 9 years ago

DanielZuwala commented 9 years ago

Sorry if it's a stupid question but I don't manage to update change in the CSS files.

But I see no change. I know that the theme is correctly installed because changes in template files are effective. So I don't get it.

The _ionisx.scss file is always empty is it ok ? The change doesn't seem to be in the sass file generated (in my case myurl/static/css/lms-main.d8d16e63defa.css)

I am missing something ?

tusbar commented 9 years ago

Hey @DanielZuwala,

The _ionisx.scss file is indeed meant to be empty as the theme does not override any Sass from Open edX.

It creates another CSS file from the Less source. That CSS file is included in https://github.com/IONISx/edx-theme/blob/master/templates/theme-head-extra.html.

I believe that you also need to restart the LMS, after running update_assets.

DanielZuwala commented 9 years ago

Hi, thanks for you answer.

I finally found the issue. I was trying to change the css of the about page of a course, and the changes were not updated. The issue was that the course/main.less is included inside a body.view-incourse selector. But when the about page of a course is loaded, the body tag doesn't have the view-incourse class.

I suppose this behavior might be considered as a bug ? I end up removing the view-incourse selector in the pages/main.less file.