Remove logs to stdout - Githubissues

mattiasberlin commented 8 months ago

Summary of the changes:

Stop logging to stdout. Instead errors are returned where appropriate, but some logs like "Skipping duplicate XAddr" and "Onvif WS-Discovery: Find Xaddr: %-25s EndpointRefAddress: %s" were simply removed. (breaking change)
NewDevice no longer does requests to the device. Instead if the user wants to obtain the endpoints/capabilities then that functionality is moved to a new device method GetSupportedServices. (breaking change)
Parse returned scopes on discovery response to populate Name (new) and Hardware fields in DeviceInfo.
Use io.ReadAll instead of the deprecated ioutil.ReadAll.
Trim .vscode/settings.json since to me it feels like most of those settings should be user settings rather than workspace settings.

I'm of course down to discuss any of these changes.

I hope it's possible to do a squash merge, otherwise tell me and I'll squash the commits in my branch.

cloudxxx8 commented 7 months ago

@mattiasberlin thanks for the contribution. Could you please separate these items to different issues and PR for easier to review?

mattiasberlin commented 7 months ago

Sure. Do you want me to write issues for the changes as well, or is it enough with the PRs?

cloudxxx8 commented 7 months ago

It could be better with the corresponding issues to describe the purpose of the changes.

IOTechSystems / onvif