IObundle / iob-eth

Basic Verilog Ethernet core and C driver functions
MIT License
10 stars 4 forks source link

Removed redundant C function #15

Closed pedrompt97 closed 3 years ago

jjts commented 3 years ago

Where is it used? Why do they have the same name? This was using a compilation error . My recommendation is to remove it if we never use it to return the full status.

JDLopes commented 3 years ago

Where is it used? Why do they have the same name? This was using a compilation error . My recommendation is to remove it if we never use it to return the full status.

Was it using a compilation error? That does not happen on iob-yolo repository. Maybe because it uses g++ instead gcc compiler, sorry. I never used eth_get_status(void). But I wrote the ethernet drivers for everyone to use, not only the functions I need. You can remove eth_get_status(void) function if you want to.

jjts commented 3 years ago

Yes, with g++ it works because of overloading. The rule is to never include stuff that is not being used. We already have a lot to do with the stuff that is used. Will merge.