IOsetting / FwLib_STC8

A lite firmware library for STC8G/STC8H series MCU
Apache License 2.0
122 stars 32 forks source link

Thanks and a fix #11

Open porcinus opened 1 year ago

porcinus commented 1 year ago

First, a huge thanks for you library. I never used a STC8 MCU before and your work greatly helped me :)

I made a "helper" file to compute and reverse compute some values related to prescalers. If you are interested, you can borrow the file or any parts of it ;) https://github.com/porcinus/NNS-Ambiclone-Mono/blob/main/code/src/FwLib_STC8_helper.h

During coding, I also notice an error (I think, haven't tried but this generate a error) in https://github.com/IOsetting/FwLib_STC8/blob/master/include/fw_rcc.h In macro RCC_SetPowerDownWakeupTimerCountdown(16BIT_COUNT): (16BIT_COUNT << 8) should be (__16BIT_COUNT__ >> 8)

IOsetting commented 1 year ago

Thanks for the report, there are quite some errors in fw_rcc.h. I have updated it accordingly. Please let me know if there are any other errors.

IOsetting commented 1 year ago

FwLib_STC8_helper.h looks nice, I will borrow some code if you don't mind :smile:

porcinus commented 1 year ago

Thanks for the report, there are quite some errors in fw_rcc.h. I have updated it accordingly. Please let me know if there are any other errors.

This was the only error i noticed :)

porcinus commented 1 year ago

FwLib_STC8_helper.h looks nice, I will borrow some code if you don't mind smile

Take any parts you want ;)