search

IPS-LMU / EMU-webApp

The EMU-webApp is an online and offline web application for labeling, visualizing and correcting speech and derived speech data.
http://ips-lmu.github.io/EMU-webApp/
MIT License
51 stars 14 forks source link

Key Mapping for non-german layouts #262

Open thilomichael opened 5 years ago

thilomichael commented 5 years ago

First, let me thank you for the EMU webApp, you are doing amazing work!

I have (had) some problems with the keyboard shortcuts of the web app. For example, the "Shrink / Expand Selected Segment" shortcuts are not working for me. The problem is that I use the U.S. keyboard layout, so I get my plus sign ("+") by pressing Shift=. So for what the App says is "Shift + +" I had to press Shift7 which is the *-symbol on the US layout.

When looking into the config file default_emuwebappConfig.json I see that the ASCII-Codes are mapped to the different functionalities, so I changed them and now it works (I use = so ASCII 61 for expand left and +/ASCII 43 for expand right). But that change breaks the functionality for other layouts.

Would it may be possible to use the keyCodes instead of ASCII codes? That way the keys stay the same in different keyboard layouts.

raphywink commented 5 years ago

Thanks 4 your kind words :-)

@Keymapping: good point! In the EMU-webApp2 we are currently using the following npm module to handle the key mapping 4 us:

https://github.com/IPS-LMU/EMU-webApp2/blob/master/src/app/main-layout/mainlayout.component.ts#L6

as far as I am aware, these work with keyCodes anyway. So that should solve the issue.