search

IPS-LMU / EMU-webApp

The EMU-webApp is an online and offline web application for labeling, visualizing and correcting speech and derived speech data.
http://ips-lmu.github.io/EMU-webApp/
MIT License
51 stars 14 forks source link

Update db-obj-load-save.service.ts #277

Closed samgregory closed 4 years ago

samgregory commented 4 years ago

Fixes needed to open wav and SSFF tracks from a GITLAB connection

raphywink commented 4 years ago

Thanks for this. I must have missed the fat arrow function conversion in that service (will go through all of the other services again today just to double check). I updated this service here: https://github.com/IPS-LMU/EMU-webApp/commit/7102a0589c04f3e7b239dc8a4a69bb7dbbe9d4b1

Unfortunately, inverting the OSCI colors would have to be configurable and would need a schema update which is why I am not accepting this pull request (should also be part of a different pull request tbh). I am rethinking of how to handle the color layout/settings anyway so that might all change in the near future which is why I'll close this pull request for now.

samgregory commented 4 years ago

Thanks Raphael, I'm still getting my head around GitHub and I didn't realise I'd put the second commit into the pull request. I'm happy for the OSCI colors to stay non-configurable although my wife's preference would be for that track to have black on white background instead of the new look white on black background.

Thanks for changing the db-obj service. Did you test the changes on a gitlab connection? Specifically I'm interested in what happens at line 194? https://github.com/IPS-LMU/EMU-webApp/blob/master/app/scripts/services/db-obj-load-save.service.ts#L194