search

IPS-LMU / EMU-webApp

The EMU-webApp is an online and offline web application for labeling, visualizing and correcting speech and derived speech data.
http://ips-lmu.github.io/EMU-webApp/
MIT License
51 stars 14 forks source link

Saving back a modified track file _fails_ due to unsupported column type error #308

Open FredrikKarlssonSpeech opened 2 years ago

FredrikKarlssonSpeech commented 2 years ago

I have a single track overlayed on the spectrogram. When I edit it and sync it back to the server, I get the error:

Skärmavbild 2022-02-24 kl 11 20 21

Not being to save back a well-formated SSFF track to the server is a serious issue.

FredrikKarlssonSpeech commented 2 years ago

The issue is that while the web app opens and manipulates SSFF tracks fine, it refuses to store the track unless it is "INT16" format.

samgregory commented 2 years ago

Hi @FredrikKarlssonSpeech - this has been a long time issue. I've made a pull request that fixes the problem. #311

MJochim commented 2 years ago

I have reviewed PR #311 and added a little code to it. I will make a new release containing the fix this week, so @FredrikKarlssonSpeech you can test it. Thanks again for the report and the PR.

MJochim commented 2 years ago

I just released this fix with v1.4.0. @FredrikKarlssonSpeech can you confirm that it works now and your data are written out correctly?

I am not yet closing this issue, because I would like some feedback on whether it works as intended. A bug in writing out data would be pretty bad. I was careful in reviewing @samgregory’s fix and didn’t spot an error. But nothing beats a test with real data.

MJochim commented 1 year ago

@FredrikKarlssonSpeech Do you have any feedback on this?