Closed stefanocoretta closed 3 years ago
Thanks for this! Will integrate into next release as I do think it is a cleaner option. However, the only thing that I don't like about such and approach is that users tend to forget what options they have set (e.g. in their .Renv file) and then end up, for example, using a really old version of the EMU-webApp (those are always super fun 2 debug -> 20 emails back and forth be4 u discover: "oh you are not on the current version... why?"). If they have to set the option explicitly at the top of their scripts after library(emuR)
it is just more explicit and better documented (doesn't mean that they forget what they where doing there and just hit cmd + enter without looking at what is actually beeing executed)
Hi! The current
.onLoad
function overrides a user-definedemuR.emuWebApp.dir
option:https://github.com/IPS-LMU/emuR/blob/5102bfcb7ee16c2569b4d2e509d43e341586df41/R/zzz.R#L1-L7
The following first checks for user-defined options and changes only non-defined ones (as of now, the functions sets only one option, but maybe in the future there'll be more). Would have done a PR, but for such a tiny change I didn't want to go through the hassle. 😅