search

IQSS / Amelia

Amelia: A Package for Missing Data
http://gking.harvard.edu/amelia
61 stars 17 forks source link

Fix build with Rtools40. #19

Closed jeroen closed 4 years ago

jeroen commented 4 years ago

We are about to roll out a new tooclhain for R on Windows and the Amelia package errors when building the vignette: https://cran.r-project.org/web/checks/check_results_Amelia.html

The culprit seems to be escape characters in vignette/Makefile which the new version of make does not like. I don't think it is needed to escape $ in make, so the current PR fixes the problem. You can confirm this by uploading your package to R-devel ATC (alternative toolchain) on winbuilder: http://win-builder.r-project.org/upload.aspx

Alternatively, I think you could remove the custom vignette/Makefile altogether, because it seems that it does exactly the same thing as what R does by default.

Could you please submit a fix to CRAN? We need to get our fail list down asap to move forward with the new toolchain.

mattblackwell commented 4 years ago

Thanks for point this out. I decided to just remove the Makefile entirely since you're right that R already does the same task. That's in the develop branch at 779d39cb547aec5ab759789f5164c075eadf4418