IQSS / Zelig

A statistical framework that serves as a common interface to a large range of models
http://zeligproject.org
109 stars 43 forks source link

testthat new release issue #313

Closed christophergandrud closed 6 years ago

christophergandrud commented 6 years ago

From Hadley via email:

This is an automated email to let you know that:

I need your help to keep Zelig and testthat working together smoothly. In the next month, can you please:

  1. Read about the changes to testthat at https://github.com/r-lib/testthat/blob/master/NEWS.md#testthat-1029000. This page includes a list of breaking changes, the reasoning behind them, and to how to update your code.

  2. Carefully inspect the failing checks listed at the bottom of this email.

  3. For each failing check, either update your package, or tell me that I have a bug. If you have made changes to your package, please submit an update to CRAN before Nov 13.

If you have discovered a bug in testthat, please file an issue (ideally with a small reprex that illustrates the problem) at https://github.com/r-lib/testthat/issues. If you're not sure whether or not you've found a bug, please an issue and we'll help you figure it out.

Thanks,

Hadley Wickham

== CHECK RESULTS ========================================

*   checking tests ...
 ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  ev
            mean         sd       50%      2.5%     97.5%
  [1,] 0.6990619 0.09467077 0.7081549 0.5028567 0.8603348
  pv
          0    1
  [1,] 0.31 0.69
  fd
             mean        sd        50%      2.5%       97.5%
  [1,] -0.2377065 0.1148547 -0.2380952 -0.466211 -0.01659926
  testthat results

================================================================ OK: 1273 SKIPPED: 0 FAILED: 1

  1. Error: REQUIRE TEST survey weights correctly passed (@test-survey.R#22)

    Error: testthat unit tests failed Execution halted

christophergandrud commented 6 years ago

Addressed in ad98e69aec06f2fd1af05d09baf33d70b2456037