IQSS / dataverse-client-javascript

A Dataverse client for JavaScript and TypeScript
MIT License
15 stars 8 forks source link

117- Create use case to get the file citation #125

Closed MellyGray closed 6 months ago

MellyGray commented 7 months ago

What this PR does / why we need it:

This PR adds a new use case getFileCitation to get the file citation given the fileId and datasetVersion.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

Suggestions on how to test this:

  1. Visual inspection of the code
  2. Check unit and integration tests execution in GitHub actions

Is there a release notes update needed for this change?:

GetFileCitation use case added to the module

Additional documentation:

MellyGray commented 7 months ago

Waiting on https://github.com/IQSS/dataverse/issues/10240

MellyGray commented 6 months ago

@ekraffmiller I updated the code to set :latest-published as the default version to match JSF behavior as you suggested

ekraffmiller commented 6 months ago

@MellyGray since we are creating an action item for fixing the default version shown as discussed here https://iqss.slack.com/archives/C06FWJ0FV2R/p1708016216373459, I think it's ok to keep everything as :latest, what do you think? Since our ultimate solution will be changing this logic anyway.

pdurbin commented 6 months ago

I'm removing the waiting label because this pull request was just merged: