58 - Automatically reformat code

MellyGray commented 7 months ago

What this PR does / why we need it:

This PR adds the automatic formatting to the repo using some pre-commit configurations. The pre-commits include:

A part from that:

I added some changes to the ESlint and prettier config files to match the SPA formatting
We were using a mix of jest, chai and sinon testing libraries, so I removed sinon and chai from the repo in favor of using only jest which simplifies the tests
Since I added a coverage check to the pre-commits I had to add some tests to match the 95% coverage threshold
I fixed some casting in some use cases because we were using the type casting as number instead of the real casting parseInt() and the tests were failing after changing from sinon assert to jest strict comparison.
I rewrote some jest config files from javascript to typescript

There are a lot of changes, but these are just formatting changes so they shouldn't affect the features.

Visual inspection of the code
Make a change to the source code in your local environment and commit the change to check that the pre-commit checks are running as expected
Uncommit the test commit

GPortas commented 6 months ago

@MellyGray Can you please resolve conflicts?

Please, do not prioritize this PR if you have other pending feature-related issues, which should be our focus for the community day.

MellyGray commented 6 months ago

@GPortas merge conflicts resolved

One question, should we merge this PR here to fix the markdown library?

GPortas commented 6 months ago

@MellyGray

Yes, I just accepted and merged the PR. Can you please resolve the conflicts?

MellyGray commented 6 months ago

@GPortas did you ran npm install to install the pre-commit package?

GPortas commented 6 months ago

@MellyGray I missed that step, thanks!