IQSS / dataverse-client-javascript

A Dataverse client for JavaScript and TypeScript
MIT License
15 stars 8 forks source link

Add getCollection use case and tests #134

Closed M27Mangan closed 5 months ago

M27Mangan commented 5 months ago

What this PR does / why we need it:

We need to implement a use case in the package for retrieving a collection. This use case will be utilized on the Collection page of the SPA.

Currently, for the SPA, we require the following properties to be added to the new collection model: name, affiliation, description, and owner information. Additionally, we need to map any other properties present in the API response payload that might be useful for any package consumer.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

Suggestions on how to test this:

Visual inspection and GitHub action review

Is there a release notes update needed for this change?:

GetCollection use case added to the module

Additional documentation:

Added documentation to READMEs

M27Mangan commented 5 months ago

@GPortas if you updated any of your .gitignore configs for this repo, please let me know. Seem to be adding a few unintentional files.

MellyGray commented 5 months ago

@ekraffmiller I reran the tests to ensure they were still passing, but now the publish action is failing because it attempted to publish the same version again. 😆 It should be fine, just ignore the failing step

ekraffmiller commented 5 months ago

@GPortas this looks good, but is it ok that the publish-gpr is failing?

Screenshot 2024-03-27 at 1 08 40 PM
GPortas commented 5 months ago

@GPortas this looks good, but is it ok that the publish-gpr is failing?

Yes, since Melina manually re-executed the GitHub action, please take a look at her comment @ekraffmiller.

@ekraffmiller I reran the tests to ensure they were still passing, but now the publish action is failing because it attempted to publish the same version again. 😆 It should be fine, just ignore the failing step