search

IQSS / dataverse-client-javascript

A Dataverse client for JavaScript and TypeScript
MIT License
15 stars 8 forks source link

Adds use cases for uploading files through direct upload API #153

Closed GPortas closed 4 months ago

GPortas commented 5 months ago

What this PR does / why we need it:

This PR includes the use cases to support file uploads through the Direct Upload API. These use cases are entirely based on the Direct Upload API, so for the review of this PR, I recommend to rely on: https://guides.dataverse.org/en/latest/developers/s3-direct-upload-api.html

Which issue(s) this PR closes:

Related PRs:

Special notes for your reviewer:

This PR does not incorporate use case functional tests because the tests are run outside the container network and we encountered issues with hostnames not being recognized for the generated destination URLs. However, coverage is still high, over 95%, and the different scenarios are tested with integration and unit tests.

Suggestions on how to test this:

Visual inspection of the code and unit and integration tests execution.

Additional documentation:

ekraffmiller commented 4 months ago

Looks good and all tests pass, merging!