IQSS / dataverse-client-javascript

A Dataverse client for JavaScript and TypeScript
MIT License
15 stars 8 forks source link

Adds use case for getting all facetable fields defined in the installation #169

Closed GPortas closed 3 weeks ago

GPortas commented 1 month ago

What this PR does / why we need it:

Adds use case for getting all facetable fields defined in the installation.

Fixes issue in createCollection use case causing affiliation and description fields to not be passed to the API.

Changes the return type of getCollectionFacet use case from a string array to a detailed facet model array.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

⚠️ Environment variables should be changed to unstable image tag before merging into develop.

Suggestions on how to test this:

Visual inspection of code and test actions.

ekraffmiller commented 3 weeks ago

@GPortas can you please resolve the merge conflicts? I think that will fix the errors in then deploy actions, and probably the lint error. Other than that it looks great 👍

GPortas commented 3 weeks ago

@ekraffmiller Adding the waiting tag since this depends on the unmerged API PR https://github.com/IQSS/dataverse/pull/10727

We will need to update the test environment variables to use develop once the mentioned PR is merged.

Actions are failing because the docker fix present on https://github.com/IQSS/dataverse-client-javascript/pull/173 is not yet merged.

g-saracca commented 3 weeks ago

Can we remove the waiting tag and update the test env variables since 10727 has already been merged?

GPortas commented 3 weeks ago

Conflicts fixed and env vars updated. Waiting tag removed @GermanSaracca

g-saracca commented 3 weeks ago

@GPortas I think we are good to merge this issue right?