search

IQSS / dataverse-client-r

R Client for Dataverse Repositories
https://iqss.github.io/dataverse-client-r
61 stars 25 forks source link

replace 'ghit' package with 'remotes' #24

Closed wibeasley closed 4 years ago

wibeasley commented 4 years ago

The package was removed/archived on CRAN May 2018. https://cran.r-project.org/package=ghit

Package ‘ghit’ was removed from the CRAN repository.

Formerly available versions can be obtained from the archive.

Archived on 2018-05-10 at the request of the maintainer Thomas J. Leeper thosjleeper@gmail.com.

The repo says

This package is now deprecated.

No further updates will be made here or sent to CRAN.

Please use remotes instead.

pdurbin commented 4 years ago

@wibeasley hello! Thank you for this pull request! Have you seen #21 about how dataverse-client-r needs a maintainer? I also posted about this over the summer at https://groups.google.com/d/msg/dataverse-community/j-cGlnpKs14/S3PW3f1MBQAJ

I don't know enough R to even properly review this pull request but perhaps @maxheld83 or @ghost or @tmrozewski or @nfultz or others mentioned in #21 can take a look? 😄 🙏

wibeasley commented 4 years ago

@pdurbin, it sounds like you're asking if I'm willing to become the package maintainer? If so, 'yes', but I don't want to cut line in front of @maxheld83, @tmrozewski, or @nfultz. (BTW, I think '@ghost' is GitHub's placeholder for a deleted user ... in this case monogan.)

I've included some more information in https://groups.google.com/forum/#!msg/dataverse-community/j-cGlnpKs14.

nfultz commented 4 years ago

The change to the vignette/travis looks fine to me in terms of getting rid of the old package, although I'd actually recommend just turning off eval for that chunk rather than actually installing anything.

pdurbin commented 4 years ago

https://travis-ci.org/IQSS/dataverse-client-r/builds/606938819 is passing and "master" is broken. I'm merging this. Thanks, @wibeasley :tada: :tada: :tada: