added more verbose error message to httr::stop_for_status

IQSS / dataverse-client-r

R Client for Dataverse Repositories

https://iqss.github.io/dataverse-client-r

61 stars 25 forks source link

added more verbose error message to httr::stop_for_status #30

Closed EdJeeOnGitHub closed 3 years ago

EdJeeOnGitHub commented 4 years ago

Returns Dataverse API error message to make debugging easier.

R CMD Check passes locally with the change.

EdJeeOnGitHub commented 4 years ago

I opened an issue here with a bit more detail.

wibeasley commented 4 years ago

@EdJeeOnGitHub, I haven't forgotten about this PR. I see that some of the master branch has changed since your modification, and I'll do my best to make sure you get credit.

Will you please

add yourself to the DESCRIPTION file as a "ctb". Add your ORCID id if you have one.
update NEWS.md to reflect this improvement?

I'm using R Packages for the definition/distinction between the "aut" and "ctb".

EdJeeOnGitHub commented 4 years ago

I think I managed to fix the conflicts too?

kuriwaki commented 3 years ago

I like this simple addition and support working to merging this PR. I added a testthat case. See also my comment https://github.com/IQSS/dataverse-client-r/issues/31#issuecomment-751801537 on the associated Issue that seeks to find one more informative test that is compatible with current master version.

kuriwaki commented 3 years ago

Also, shouldn't we implement the same change in the dozens of other places where httr::stop_for_status is called -- not just in get_file()?