IQSS / dataverse-client-r

R Client for Dataverse Repositories
https://iqss.github.io/dataverse-client-r
61 stars 24 forks source link

package scaffolding #38

Closed wibeasley closed 2 years ago

wibeasley commented 4 years ago

As I've expressed with a few tweaks:

I'd (like to) modify some of the package's structure to more closely resemble the approach described in Hadley's R Packages book (and the tidyverse style guide). The first reason is because I think it's a good approach and has worked well for me in the past. A second reason is that this approach is documented better and more coherently than any other approach --therefore it will be easier for someone else to modify or become maintainer in the future.

But this won't be a major overhaul. Most of the important elements of the existing package follow this book's approach.

The changes come in two sets: the little guys that come before adding a test suite (issues #4 & #29) and those that come after the test suite (which includes some of the recently accumulating issues like #33, #35, & #37).

Before test suite

After test suite and functional changes

I'm flexible if anyone has other ideas.

pdurbin commented 4 years ago

my request for additional permissions granted to Codecov

Yes, you may have seen that @whorka approved this request earlier today. Thanks for working on the tests! 🎉

kuriwaki commented 2 years ago

This tidyverse style package scaffolding seems largely complete. The issues in the create_* functions will get dealt with using the same scaffolding. Thanks @wibeasley !!