IQSS / dataverse-client-r

R Client for Dataverse Repositories
https://iqss.github.io/dataverse-client-r
61 stars 25 forks source link

Simplify and update vignettes #90

Closed kuriwaki closed 3 years ago

kuriwaki commented 3 years ago

This PR makes updates to vignettes for v0.3.x+. They had not been updated since v0.2.0.

Danny-dK commented 3 years ago

Are you sure you want to remove the sword references? For now that's the only way that I am able to upload datasets. #82

kuriwaki commented 3 years ago

@Danny-dK I missed that sword does work (I was trying to remove parts that have any problems). If you have any updates to that issue, that'll be great when I take a look today.

We included informative error messages in the latest master version (#30)

Danny-dK commented 3 years ago

@kuriwaki No worries. I added a summary in #82 of the code that now works and what doesn't work (as it was indeed getting a bit much in unstructured information).

kuriwaki commented 3 years ago

I updated the part of the README with your example (with eval = FALSE). It is similar to the archiving vignette that was deleted and can be added back.

But given that this is a workaround and there are some questions (e.g. the workaround a mixup of SWORD vs. native API), I'd rather publish a version for which all examples work. The fixes to the the uploading is perhaps a 0.4.0 milestone or pyDataverse task.

@wibeasley what do you think?

wibeasley commented 3 years ago

Looks good, @kuriwaki & @Danny-dK, thanks for keeping all the parts straight.