search

IQSS / dataverse-frontend

An upcoming and modernized UI for Dataverse
Apache License 2.0
20 stars 16 forks source link

Remove the skip from e2e test for getByPersistentId, so the test case could be included #543

Closed ChengShi-1 closed 2 weeks ago

ChengShi-1 commented 2 weeks ago

What this PR does / why we need it:

The test case of getByPersistentId should also work for deaccessioned datasets. The it.skip() should be removed because the JS dataverse has included deaccessioned api.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

It would be fine if e2e test DatasetJSDataverseRepository running well with no error message.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

coveralls commented 2 weeks ago

Coverage Status

coverage: 97.572% (+0.2%) from 97.388% when pulling 159058a685b0b37841fca95ae699ba7104c8c559 on 535-implement-the-getdatasetcitation-once-it-includes-deaccessioned-datasets into 110d6963fe8d97c187665a1f182a4ba96589f478 on develop.

ofahimIQSS commented 2 weeks ago

Test Ran successfully - merging pr

✔  All specs passed!                        01:22       12       11        -        1        -