search

IQSS / dataverse-jenkins

configs and docs for running continuous integration for Dataverse in Jenkins
0 stars 1 forks source link

fix PR 18, make imported job name a group_var #20

Closed donsizemore closed 4 years ago

donsizemore commented 4 years ago

Closes #19

pdurbin commented 4 years ago

@donsizemore I left a small review about "OdumInstitute" vs "IQSS". I can't remember which one we said we wanted.

Also, a better title for this pull request would help at standup. 😄 The way I put it is that I want reproducible builds for Dataverse, if that helps.

pdurbin commented 4 years ago

@donsizemore thanks, as always, for continuing the build for the Dataverse community all this testing infrastructure!

I recently re-watched "Agile Product Ownership in a Nutshell" by Henrik Kniberg and this line really jumped out at me:

"In order to maintain this pace, and not get bogged down by manual regression testing, the team invests heavily in automated testing and continuous integration. Every feature has automated acceptance tests, and most of the code has automated unit tests." -- https://blog.crisp.se/2012/10/25/henrikkniberg/agile-product-ownership-in-a-nutshell

The work you are doing will accelerate the whole project and ultimately save a lot of money in developer and QA salary. THANK YOU!

Unfortunately, this pull request didn't "just work" for me (I'm on c44ac5a) in the sense that plugins were not installed:

IQSS-Dataverse-Develop_Config_ Jenkins _-_2019-10-29_11 59 24

Screen Shot 2019-10-29 at 11 58 49 AM

I spun it up like this:

ec2/ec2-create-instance.sh -b ice_cream_cookies -r https://github.com/OdumInstitute/dataverse-jenkins.git

I think I'll try a few things on this instance. Restart Jenkins, try to install plugins manually (maybe we should just document this step?).

Thanks again for all the work on this! 🎉 🎉 🎉

pdurbin commented 4 years ago

I just spun up Jenkins as of d3a6645 and now I see lots of plugins at http://ec2-3-85-236-79.compute-1.amazonaws.com:8080/pluginManager/installed

Update_Center_ Jenkins _-_2019-11-01_14 49 49

pdurbin commented 4 years ago

The job is looking pretty good:

IQSS-Dataverse-Develop_Config_ Jenkins _-_2019-11-01_14 52 42

I'm thinking I might try "Build Now" and watch it fail to see what happens if you haven't plugged in your AWS credentials yet.

pdurbin commented 4 years ago

Merged. Thanks, @donsizemore !

Importing a job "just works" now. We'll pick up the AWS credentials stuff in #21