IQSS / dataverse

Open source research data repository software
http://dataverse.org
Other
873 stars 482 forks source link

Thumbnails are displayed when a guestbook is activated #10679

Open DS-INRA opened 1 month ago

DS-INRA commented 1 month ago

What steps does it take to reproduce the issue? Create a dataset, Add an image to create a thumbnail Set a guestbook on the dataset Log out and view the dataset page

Which version of Dataverse are you using? 5.14

Any related open or closed issues to this bug report?

On thumbnails and restricted files :

On thumbnails code:

Screenshots:

https://github.com/IQSS/dataverse/assets/46443753/f9570277-b679-45e2-8e56-d1f6bceebf69

pdurbin commented 1 month ago

Interesting. This feels like a regression to me. I don't think we used to show thumbnails when a guestbook is enabled. It should be hidden, like it is for restricted files.

@DS-INRA if you happened to have tested this on https://demo.dataverse.org (6.2, currently) or https://beta.dataverse.org (develop branch) please let us know!

DS-INRA commented 1 month ago

Thanks for the suggestion. I have tested both beta and demo. The behaviour is the same with demo: image https://demo.dataverse.org/dataset.xhtml?persistentId=doi%3A10.70122%2FFK2%2F8FKJT2 But the thumbnail is hidden on beta: https://beta.dataverse.org/dataset.xhtml?persistentId=doi:10.5072/FK2/YJ6MTI