IQSS / dataverse

Open source research data repository software
http://dataverse.org
Other
888 stars 490 forks source link

Login: Remove the Login System select box from the login page. #1081

Closed kcondon closed 10 years ago

kcondon commented 10 years ago

The Login System select box was a debug tool that lets you choose build-in provider (sp), dignified echo provider, and echo provider.

pdurbin commented 10 years ago

Right. @michbarsinai added it but I don't think it's used except for testing.

When Shib is enabled we should clearly label the non-Shib login as "local" or something (see https://discovery.refeds.org/demo/good/step-two/ ) so that Shibboleth Identity Providers don't think we are phishing for passwords. @mheppler and I have talked about this.

pdurbin commented 10 years ago

@mheppler is on this.

mheppler commented 10 years ago

Login System dropdown is GONE. This has also restored the focus on the username input field on the login page. (In related news, I noticed that the focus was missing from the dataverseuser page on Sign Up, and password reset, so I added it there.)

scolapasta commented 10 years ago

For things like this, when we remove them, but they're useful for testing, can we use ui:remove tags instead if removing them completely?

kcondon commented 10 years ago

There was a way to disable through the scripts -I think using identiyproviders.sh Just saying, appreciate the work.

michbarsinai commented 10 years ago

IIRC, the menu was hidden automatically when there was only a single provider enabled.

On Dec 4, 2014, at 00:38, kcondon notifications@github.com wrote:

There was a way to disable through the scripts -I think using identiyproviders.sh Just saying, appreciate the work. — Reply to this email directly or view it on GitHub https://github.com/IQSS/dataverse/issues/1081#issuecomment-65504632.

kcondon commented 10 years ago

Gone baby gone.

mheppler commented 10 years ago

Added back deleted Login System block of code from loginpage and used ui:remove tag instead to hide it from rendering in the browser.