Dataset UI - Terms Tab - Restricted Files section is displayed even when there is no data present

[ofahimIQSS]

What steps does it take to reproduce the issue? Steps:

1. Go to the dataverse site (https://dataverse-internal.iq.harvard.edu/)
2. Login using valid credentials | if you are not registered, please create an account
3. Create a New Dataset
4. Under Description, enter test
5. Subject: Pick any subject
6. Save the data set.
7. Navigate to the Terms Tab and look under "Restricted Files+Terms of Access"

• When does this issue occur?

• Right after publishing a new Dataset

• Which page(s) does it occurs on? Dataset page on Terms Tab - example of issue can be found here: https://dataverse-internal.iq.harvard.edu/dataset.xhtml?persistentId=doi%3A10.70122%2FFK2%2FEDABWF&version=DRAFT

• What happens? "Restricted Files+Terms of Access" is displayed even when there isn't any data present.

• What did you expect to happen? Spoke to Julian about this - Julian confirmed that when none of the fields are filled, we don't expect the section to appear at all.

Which version of Dataverse are you using? Dataverse Prod and Internal

Any related open or closed issues to this bug report? N/A

Screenshots:

[ofahimIQSS]

Reproduced in production (v. 6.3 build 8c99a74+10614+10720+10808+10797+10820-iqss) v. 6.3 build 8c99a74+10614+10720+10808+10797+10820-iqss Reproduced in Demo 6.4 Release Candidate

[sekmiller]

I'm not seeing in on Demo which has the 6.4 release candidate, I think

[pdurbin]

I can reproduce it on demo (yes, it's running a 6.4 release candidate).

I created the dataset in the root collection but I doubt that matters.

Here's a screenshot:

The bug is in JSF, which we're throwing away 🗑️ in favor of React so I'm not sure if this is worth fixing. /me ducks

[sekmiller]

My working theory is that this is due to the "Request Access to Restricted Files" being true by default. The reason I wasn't seeing it in my prior datasets was because I was using a template on create where "Request Access...." was false.

[sekmiller]

Mentioned this in standup on Monday - the fix was simple enough that there's no need for further discussion. (My original thought was that it could be complex or require changing a default dataset setting. fortunately that is not the case)