search

IQSS / dataverse

Open source research data repository software
http://dataverse.org
Other
882 stars 494 forks source link

Update the conditions to display image_url in Solr search results for file type #10886

Closed stevenwinship closed 3 weeks ago

stevenwinship commented 1 month ago

What this PR does / why we need it: fixes the conditions in which the visibility of the image_url field is included in the search results.

Which issue(s) this PR closes:https://github.com/IQSS/dataverse/issues/10875

Closes #10875

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: No

Additional documentation: See https://github.com/IQSS/dataverse/pull/10855

coveralls commented 1 month ago

Coverage Status

coverage: 20.868% (-0.001%) from 20.869% when pulling cb6e44f0d58f72aea6bae7476d85fa79ca2b31b7 on 10875-update-conditions-to-display-image_url into a0cb73de53505654c6d7dd20021006973ee2febc on develop.

github-actions[bot] commented 1 month ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10875-update-conditions-to-display-image-url
ghcr.io/gdcc/configbaker:10875-update-conditions-to-display-image-url

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 1 month ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10875-update-conditions-to-display-image-url
ghcr.io/gdcc/configbaker:10875-update-conditions-to-display-image-url

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 1 month ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10875-update-conditions-to-display-image-url
ghcr.io/gdcc/configbaker:10875-update-conditions-to-display-image-url

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 1 month ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10875-update-conditions-to-display-image-url
ghcr.io/gdcc/configbaker:10875-update-conditions-to-display-image-url

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] commented 1 month ago

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:10875-update-conditions-to-display-image-url
ghcr.io/gdcc/configbaker:10875-update-conditions-to-display-image-url

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

pdurbin commented 1 month ago

API tests didn't run. At standup @stevenwinship said he'd take a look (thanks): https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10886/5/testReport/

stevenwinship commented 1 month ago

I re-ran the tests and they all passed. https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10886/6/

ofahimIQSS commented 3 weeks ago

@stevenwinship Uncovered an issue while testing this PR. Collection Thumbnails aren't displayed on homepage when adding a logo, thumbnail, and footer images to a collection.

  1. Create a new Collection
  2. Edit Collection> Theme + Widgets
  3. Upload Logo, Thumbnail, and Footer Images
  4. Publish Collection
  5. Navigate to homepage --- here is where the issue lies: Notice that the thumbnail still displays default Dataverse Collection thumbnail instead of what was just uploaded.
stevenwinship commented 3 weeks ago

RE: Navigate to homepage --- here is where the issue lies: Notice that the thumbnail still displays default Dataverse Collection thumbnail instead of what was just uploaded.

This issue exists in develop branch and is not caused by this PR

ofahimIQSS commented 3 weeks ago

Confirmed testing with Steve - no issues found with PR. Merging Testing of 10886.docx